some more proc_macro cleanups
#147386
some more proc_macro cleanups
#147386
Conversation
rustbot
added
the
S-waiting-on-review
|
rustbot has assigned @petrochenkov. Use |
|
The second commit makes sense to me, the arena's use is limited, and if the |
| self.grow(bytes); | ||
| if let Some(a) = self.alloc_raw_without_grow(bytes) { | ||
| // SAFETY: the lifetime is extended here, but then constrained again in `alloc_str`. | ||
| return unsafe { &mut *(a as *mut _) }; |
There was a problem hiding this comment.
Is it possible to remove the internal mutability without this change?
I'm not sure how it's related to the rest of the commit.
There was a problem hiding this comment.
The unsafe is unfortunately needed to avoid an error[E0499]: cannot borrow *self as mutable more than once at a time. (This would be fixed with -Zpolonius.)
I removed the loop because grow will always produce enough space to hold the data, so it seemed a bit clearer to me this way (with the old code, I thought at first that grow might need to be called many times).
There was a problem hiding this comment.
Let's keep the cells then.
The loop can still be refactored to if let or unwrap_or_else though.
petrochenkov
added
S-waiting-on-author
Several smaller cleanups to
proc_macro. Commits 1 and 3 seem pretty trivial to me, commit 2 might be worth it or not.Followup to #147166.